⚠️ No Changeset found

Latest commit: e9d3ecd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Thanks for the thorough review @pcattori! 🙏

Fixed all the remarks & some minor other things as well, so should be good to be merged now.

Hi @MichaelDeBoey, this PR causes issues (or leaves them unfixed?) at least with docs/guides/data-writes.md where setting defaultValues as per the documentation throws the following type error (see https://remix.run/docs/en/v1/guides/data-writes#graduate-to-form-and-add-pending-ui):

Type 'string | SerializeObject<UndefinedToOptional<File>> | undefined' is not assignable to type 'string | number | readonly string[] | undefined'.
  Type 'SerializeObject<UndefinedToOptional<File>>' is not assignable to type 'string | number | readonly string[] | undefined'.ts(2322)
index.d.ts(1851, 9): The expected type comes from property 'defaultValue' which is declared here on type 'DetailedHTMLProps<InputHTMLAttributes<HTMLInputElement>, HTMLInputElement>'

I can make a PR to fix it, but not actually sure if it's supposed to work that way (I'm a Remix noob)

edit: Or that the issue is that the values are returned with Object.entries(formData), explicitly changing that to {name: formData.get('name')?.toString(), password: formData.get('password')?.toString()} makes them string | undefined that doesn't cause issues.